This repository was archived by the owner on Sep 11, 2019. It is now read-only.
Replaced btoa and atob that have a problem with handling Unicode characters with code by Johan Sundström.#4
Open
zigah wants to merge 2 commits intoplaygameservices:masterfrom
Open
Replaced btoa and atob that have a problem with handling Unicode characters with code by Johan Sundström.#4zigah wants to merge 2 commits intoplaygameservices:masterfrom
zigah wants to merge 2 commits intoplaygameservices:masterfrom
Conversation
…racters with code by Johan Sundström.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two new functions in b64Utils.js are intended to replace btoa and atob that have a problem with handling Unicode caharacters in a player's g+ name - like mine :P - and throw an exception, which prevents the Brag button to populate.
The functions below were effectively copy pasted from ecmanaut.blogspot.com
as suggested by MDN: https://developer.mozilla.org/en-US/docs/Web/API/window.btoa
and written by Johan Sundström:
"In most browsers, calling window.btoa on a Unicode string
will cause a Character Out Of Range exception.
To avoid this, consider this pattern, noted by Johan Sundström:"
http://ecmanaut.blogspot.com/2006/07/encoding-decoding-utf8-in-javascript.html